Skip to content

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Oct 30, 2018

Copy link
Contributor

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Thanks! I will wait for the others before merging.


## Solver
The main kind of tests in chalk are **goal tests**. They contain a program,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this name up, but it seemed reasonable to me!

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good!

@nikomatsakis nikomatsakis merged commit 9fe13e7 into rust-lang:master Nov 2, 2018
@tmandry tmandry deleted the improve-chalk-overview branch November 2, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants